fix(v2): properly link top-level github pages sites in deploy command #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 8553aaa |
yangshun
suggested changes
Apr 8, 2020
|
Sorry @yangshun, fixed now |
lex111
suggested changes
Apr 12, 2020
lex111
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Found this issue while trying to make a site, so I fixed it
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
I tested it by creating a docusaurus site and I verified that the correct URLs are logged.
Related PRs
This was in #2556 but @yangshun reverted it